fmgasparino / google-gin

Automatically exported from code.google.com/p/google-gin
Apache License 2.0
0 stars 0 forks source link

Errors in private modules have the wrong source location #158

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a private module with an error that Gin can detect (e.g., require an 
annotated class and don't define a binding for it).

What is the expected output? What do you see instead?

The portion of the error relating to bindings in the private module should 
refer to a line in the file defining that module.  Instead, it refers to a 
source location in one of Gin's internal classes.

The problem is that source locations are computed by Guice, but the user 
doesn't invoke Guice directly from a private module; instead, calls to Guice 
are passed through adapter classes in Gin.  So Guice gives a Gin source 
location as the caller of the EDSL method that created the binding.

Original issue reported on code.google.com by dburr...@google.com on 26 May 2011 at 8:49

GoogleCodeExporter commented 9 years ago
A patch containing a fix for this is submitted for review at: 
http://codereview.appspot.com/4967042/

Original comment by aragos on 26 Aug 2011 at 5:28

GoogleCodeExporter commented 9 years ago
Fixed in r226.

Original comment by aragos on 16 Sep 2011 at 3:36