@Provides on GinModule that is an inner class produces invalid Ginjector source

fmgasparino / google-gin

Automatically exported from code.google.com/p/google-gin

Apache License 2.0

0 stars 0 forks source link

@Provides on GinModule that is an inner class produces invalid Ginjector source #39

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

If a GinModule has a provider method, the generated Ginjector does not
compile. Errors are like:

[ERROR] Line 81: The nested type
com.google.gwt.inject.client.InnerGinjectorTest$InnerModule cannot be
referenced using its binary name

Original issue reported on code.google.com by bsto...@google.com on 28 May 2009 at 9:31

GoogleCodeExporter commented 9 years ago

Original comment by bstoler+code@google.com on 28 May 2009 at 9:33

Changed state: Started

GoogleCodeExporter commented 9 years ago

Patch sent for review: http://codereview.appspot.com/63166

Original comment by bstoler+code@google.com on 28 May 2009 at 9:47

GoogleCodeExporter commented 9 years ago

Fixed in r104.

Original comment by bstoler+code@google.com on 28 May 2009 at 10:01

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Awesome, the new @Provides is going to really clean up our code. Thanks!

Original comment by arthur.k...@gmail.com on 29 May 2009 at 1:15