toProvider bindings don't work with nested classes

[GoogleCodeExporter]

bind(Foo.Bar.class).toProvider(FooBarProvider.class); 

The following error message appears in the GWT complilation log: "The
nested type Foo$Bar cannot be referenced using its binary name" 

I'm using a version built from head on 24 September 2009. 

See discussion group topic at
http://groups.google.com/group/google-gin/browse_thread/thread/9f79bfe5cf7e1488

Original issue reported on code.google.com by dp.byand...@gmail.com on 25 Sep 2009 at 8:41

[GoogleCodeExporter]

I had some time before lunch and not much to do. The
ImplicitProviderBinding#writeCreatorMethods is working with binary names 
instead of
source names. Maybe http://pastie.org/631466 will be easier to read than a diff 
file.

If you use nested nested types like com.foo.Foo.Bar.Baz. 
ClassType#getBinaryClassName
should return com.foo.Foo$Bar$Baz but instead only the last '.' is changed to 
'$'.
replaceLast works in some cases but not all.

Original comment by alen_vre...@yahoo.com on 26 Sep 2009 at 11:40

[GoogleCodeExporter]

Patch submitted fro review: http://codereview.appspot.com/125052

Original comment by aragos on 27 Sep 2009 at 4:42

• Changed state: Review

[GoogleCodeExporter]

Fix submitted in r115.

Original comment by aragos on 1 Oct 2009 at 3:49

• Changed state: Fixed