search

fmgasparino / google-gin

Automatically exported from code.google.com/p/google-gin
Apache License 2.0
0 stars 0 forks source link

HigherLower sample source code "typo" #62

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Check-out source code from the readonly SVN trunk
2. View source file:
samples/HigherLower/src/com/google/gwt/gin/higherlower/client/Walter.java
3. Notice that there is a direct dependency on DefaultHigherLowerGame on
lines 18 and 23

What is the expected output? What do you see instead?
I would expect to see in the source:
...
private final Provider<HigherLowerGame> higherLowerGameProvider;
...
public Walter(Provider<HigherLowerGame> higherLowerGameProvider, ScoreBoard
scoreBoard,
      GameDialogs gameDialogs, @StartGame Button button) {
...

rather than:
...
private final Provider<DefaultHigherLowerGame> higherLowerGameProvider;
...
public Walter(Provider<DefaultHigherLowerGame> higherLowerGameProvider,
ScoreBoard scoreBoard,
      GameDialogs gameDialogs, @StartGame Button button) {
...

What version of the product are you using? On what operating system?
trunk revision 117

Please provide any additional information below.
While this may be a low priority issue in the grand scheme of things, it is
a bit of a distraction for those newbies among us trying to learn by example.

Original issue reported on code.google.com by jeffrey....@gmail.com on 31 Oct 2009 at 2:53

GoogleCodeExporter commented 9 years ago 
I haven't looked at it but you're probably right. However, since a new example 
is
coming up and the higherLower one might be retired, I'll give this very low 
priority.

Original comment by aragos on 31 Oct 2009 at 5:19

GoogleCodeExporter commented 9 years ago 
Which new example is coming up and when?

Also, why not add a gameprovider and fix this till we have a new example?

Original comment by misra.abby@gmail.com on 9 Mar 2010 at 6:43

GoogleCodeExporter commented 9 years ago 
The new example can be found here:
http://code.google.com/p/google-gin/source/browse/#svn/trunk/samples/simple - 
it is
the official example for the 1.0 release. Please use that example (or unit 
tests for
more specific questions).

Original comment by aragos on 9 Mar 2010 at 8:53