fmgasparino / google-gin

Automatically exported from code.google.com/p/google-gin
Apache License 2.0
0 stars 0 forks source link

ant build fails if gwt.home point to a gwt-2.0.0 installation #73

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Check out the trunk
2. point gwt.home ant variable to a gwt-2.0.0 installation
3. run the build (I actually just wanted to build the jar so I just ran clean, 
compile.production, dist targets)

What is the expected output? What do you see instead?

Instead of having a successfull build, compilation fails because of gwt-dev 
classes not being found, you'll find the full output in the attached file 
named failed-build.txt

What version of the product are you using? On what operating system?

Just checked out trunk revision 119. On Mac OS X 10.5.8, the ant tasks are 
run from Eclipse Galileo 3.5(Build id: 20090920-1017)

Please provide any additional information below.

To get a successful build for those tasks (clean, compile.production, dist) 
change line 44 in the build.xml from:
    <fileset dir="${gwt.home}" includes="gwt-dev-*.jar"/>
to:
    <pathelement location="${gwt.home}/gwt-dev.jar"/>

I also attach a patch for build.xml but it doesn't repair the compile.tests 
task

Original issue reported on code.google.com by diaz.sal...@gmail.com on 13 Dec 2009 at 12:04

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks, I'll see if I can tweak the build file so it accepts both versions.

Original comment by aragos on 13 Dec 2009 at 3:58

GoogleCodeExporter commented 9 years ago
Thank you for the quick answer.

Original comment by diaz.sal...@gmail.com on 14 Dec 2009 at 2:26

GoogleCodeExporter commented 9 years ago
I wrote a patch that covers this issue and updates the tests to GWT 2.0. Please
review it at: http://codereview.appspot.com/179100

Once the review has been completed I'll check the changes in.

Original comment by aragos on 18 Dec 2009 at 5:01

GoogleCodeExporter commented 9 years ago

Original comment by aragos on 18 Dec 2009 at 5:02

GoogleCodeExporter commented 9 years ago
Submitted in r123.

Original comment by aragos on 21 Dec 2009 at 4:27

GoogleCodeExporter commented 9 years ago
I have downloaded Gin 126 and tried to build using Ant in Eclipese 3.5 but get 
the 
following:
init:
clean:
   [delete] Deleting directory C:\Developer\Workspace\Gin\trunk\out
compile.production:
    [mkdir] Created dir: C:\Developer\Workspace\Gin\trunk\out\production
    [javac] Compiling 44 source files to 
C:\Developer\Workspace\Gin\trunk\out\production

BUILD FAILED
C:\Developer\Workspace\Gin\trunk\build.xml:106: Error running javac.exe compiler

I have checked the GWT_HOME environment variable and have set basedir via 
Run>Ant... 
but cannot make progress. I am sure it is a problem with my poor understanding 
of 
the Ant build process so request that gin.jar be made available for download if 
at 
all possible!

Original comment by chris%ca...@gtempaccount.com on 28 Dec 2009 at 9:55

GoogleCodeExporter commented 9 years ago
I built it yesterday and it worked without issue. Perhaps you're not pointing 
to a JDK? 

Original comment by larse...@gmail.com on 29 Dec 2009 at 7:12