search

fmgasparino / google-gin

Automatically exported from code.google.com/p/google-gin
Apache License 2.0
0 stars 0 forks source link

support JSR-330 annotations #75

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
It would be really cool if Google GIN supported JSR-330 annotations. It looks 
like Guice already 
supports it in 2.1: http://code.google.com/p/google-guice/issues/detail?id=424

Perhaps no additional work will be required once Guice 2.1 is out?

Original issue reported on code.google.com by arthur.k...@gmail.com on 20 Jan 2010 at 1:49

GoogleCodeExporter commented 9 years ago 
This will require some tweaking of the Gin APIs (replacing Guice types by their
javax.inject supertypes, i.e. com.google.inject.Provider -> 
javax.inject.Provider). I
started this as part of another patch and will send in a request for review 
soon.

Original comment by aragos on 19 Apr 2010 at 3:51

GoogleCodeExporter commented 9 years ago 
This is mostly finished, excepting @Named which requires a guice issues to be
resolved: http://code.google.com/p/google-guice/issues/detail?id=425

I already created a code review at http://codereview.appspot.com/962042 since I 
don't
expect any further changes to this code for anyone who's interested.

Original comment by aragos on 22 Apr 2010 at 1:49

GoogleCodeExporter commented 9 years ago 
This patch is now complete (the Guice issue has been fixed). Please review for 
quick
integration into the codebase!

http://codereview.appspot.com/962042

Original comment by aragos on 26 Apr 2010 at 12:04

GoogleCodeExporter commented 9 years ago 
Committed in r139. :)

Original comment by aragos on 17 May 2010 at 5:34