search

fmgasparino / gwt-phonegap

Automatically exported from code.google.com/p/gwt-phonegap
0 stars 0 forks source link

GeoLocation missing functionalities #40

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The accuracy function doesn't exist in gwt-phonegap-1.5. I have searched into 
the api source (cordova-1.5.0.js) and I have found the property 'this.accuracy' 
but I have not found 'this.accuracy.horizontal'. I think that is there any 
change (in cordova-1.5.0.js) when the gwt-phonegap-1.5.0 was created and now...

Is able to fix this functionality and create the getAccuracy function?

Another point, the function 'getCurrentPosition' doesn't have any 
geoLocationOptions params. Is all right? 

Thank you!

Original issue reported on code.google.com by yosauron...@gmail.com on 30 Apr 2012 at 11:36

GoogleCodeExporter commented 8 years ago 
you are absolutely right.

The accuracy has changed in the recent phonegap distribution. The current trunk 
(which relies on phonegap 1.7) does reflect those changes.

Also I have added a getCurrentLocation with an options object.

This will be part of the gwt phonegap 1.7.x.x releases

Original comment by kurka.da...@gmail.com on 30 Apr 2012 at 1:45

GoogleCodeExporter commented 8 years ago 
Do you know when will be released the gwt phonegap 1.7? 

Thank you Daniel!

Original comment by yosauron...@gmail.com on 30 Apr 2012 at 1:52

GoogleCodeExporter commented 8 years ago 
phonegap 1.7 should be released today, after that I will do some testing, to 
see if everything is working as expected and I will be releasing gwt phonegap 
after that. So it should be within a couple of days.

There is one very important fix to phonegap that I am waiting for, in order for 
gwt apps to work better. This will be in phonegap 1.7

Original comment by kurka.da...@gmail.com on 30 Apr 2012 at 1:55

GoogleCodeExporter commented 8 years ago 
Your works it's really incredible, I'm very impressed and grateful with it. 

Thank you for your contribution!

Original comment by yosauron...@gmail.com on 30 Apr 2012 at 2:45

GoogleCodeExporter commented 8 years ago 
well thank you for reporting issues as well!

Original comment by kurka.da...@gmail.com on 30 Apr 2012 at 3:00

GoogleCodeExporter commented 8 years ago 
Hi Daniel, 

I have download the 1.7 release :D. 

I have saw that you have included the 'getAccuracy' function and have added 
another  'getCurrentPosition' adding 'geoLocationOptions'. Thank you. 

I have tested the 'getAccuracy' and I got and 'undefined' value. I think that 
may be a error in the function 
com.googlecode.gwtphonegap.client.geolocation.js.CoordinatesJsImpl.getAccuracy()
. 
Current code is: 

    public native double getAccuracy()/*-{
        return this.accuracy.horizontal;
    }-*/;

I think that it should be: 

    public native double getAccuracy()/*-{
        return this.accuracy;
    }-*/;

What do you think?

Original comment by yosauron...@gmail.com on 4 May 2012 at 5:15

GoogleCodeExporter commented 8 years ago 
you are right, this is now fixed in trunk. In a few days I will be realease gwt 
phonegap 1.7.0.1 to fix this for everyone....

Original comment by kurka.da...@gmail.com on 4 May 2012 at 8:27

GoogleCodeExporter commented 8 years ago 
Thank you Daniel

Original comment by yosauron...@gmail.com on 4 May 2012 at 9:33

GoogleCodeExporter commented 8 years ago

Original comment by kurka.da...@gmail.com on 14 Jun 2012 at 6:18