search

fmgasparino / gwt-phonegap

Automatically exported from code.google.com/p/gwt-phonegap
0 stars 0 forks source link

Added header support to FileTransferJsImpl #61

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
FileTransferJsImpl and FileUploadOptions did not have the PhoneGap headers 
feature.

Added and tested in clone:

http://code.google.com/r/frankmena-filetransferheaders/

Original issue reported on code.google.com by frank.mena on 4 Dec 2012 at 2:34

GoogleCodeExporter commented 8 years ago 
Sorry, I should have made it an enhancement.

Original comment by frank.mena on 4 Dec 2012 at 2:34

GoogleCodeExporter commented 8 years ago 
I can`t find any commit in that repository and we already do have header 
support for file upload (it is named setParams) and accepts a hashmap.

Please verify your repo and send a pull request if this is not resolved

Original comment by kurka.da...@gmail.com on 4 Dec 2012 at 6:47

GoogleCodeExporter commented 8 years ago 
I checked in the files in my clone using Tower.  I do not understand why then 
do not show up, so I attached the files to this comment.

params are not the same thing as headers.  Take a look at the PhoneGap Android 
FileTransfer source:

https://github.com/apache/incubator-cordova-android/blob/master/framework/src/or
g/apache/cordova/FileTransfer.java

starting on line 292, then look at lines starting on line 269.  I believe 
params are somehow used for multi-part, but not for HTTP headers.

Either way, when using your plugins, params are not added as HTTP headers.  The 
changes I made does.  I added a new contractor to FileTransferOptions.java to 
add the new parameter, and added the headers to FileTransferJsImpl.java.  If 
attaching the files to this comment does not work for you, please let me know.  
Sorry for the confusion.

Frank

Original comment by frank.mena on 5 Dec 2012 at 12:55

Attachments:

GoogleCodeExporter commented 8 years ago 
This issue was closed by revision 444d5afcbda4.

Original comment by kurka.da...@gmail.com on 22 Feb 2013 at 11:46

GoogleCodeExporter commented 8 years ago

Original comment by kurka.da...@gmail.com on 22 Feb 2013 at 11:46

GoogleCodeExporter commented 8 years ago

Original comment by kurka.da...@gmail.com on 30 Mar 2013 at 9:57