search

fmguerreiro / unison-ts-mode

Emacs major mode for the Unison language
MIT License
3 stars 1 forks source link

Version 1 release TODOs #1

Open fmguerreiro opened 10 months ago

fmguerreiro commented 10 months ago

This is what I have left to do before this is ready for general use:

This issue is for me to keep track of what needs to be done, not for gathering feedback. Anyone should feel free to open a separate issue if they have a question, bug, request, etc.

zetashift commented 5 months ago

Just one thing I think broke most of the useful highlighting is that unique and structural now is optional. So types are now not all highlighted

fmguerreiro commented 5 months ago

Just one thing I think broke most of the useful highlighting is that unique and structural now is optional. So types are now not all highlighted

Thanks for the report! This would be an issue with the treesitter grammar we depend on. If structural or unique are missing, then the related type_signature token we look for will not be issued in the first place. But I see this has been fixed fairly recently: https://github.com/kylegoetz/tree-sitter-unison/commit/fb9585d775a0f415b874328037a7b0710493bbaf, so I'll update the grammar branch with the newer version and that'll fix it

zetashift commented 5 months ago

Thank you for looking at this! I believe I was mistaken when mentioning things broke. It seems on Emacs 30 that most of my highlighting is borked anyway, I'll have to do some digging to see what went wrong with my config.

so I'll update the grammar branch with the newer version and that'll fix it

I believe having a seperate repo now is not necessary, as the parser.c and scanner.c are now included in the main branch of kylegoetz/tree-sitter-unison.

Thank you for your time! :D