search

fmi-basel / gliberal-scMultipleX

Feature extraction and linking of multiplexing data.
BSD 3-Clause "New" or "Revised" License
8 stars 0 forks source link

Not depending on `fractal-tasks-core[fractal-tasks]` may introduce import errors #113

Closed tcompa closed 2 months ago

tcompa commented 3 months ago

For your info, we have spotted the following issue related to how scMultiplex depends on fractal-tasks-core:

I think it will be fixed or mitigated on the fractal-task-core side, but I'm re-raising the issue here to let you know that you may find a ModuleNotFoundError due to this reason.

In case this becomes a blocking issue, I think that a temporary solution would be to add image_registration as a dependency for scMultiplex.

jluethi commented 3 months ago

For the moment: Let's not update to the fractal-tasks-core 1.1.0 dependency (or higher) in scmultiplex until this has been resolved.

My bad for adding this to that utils module / using a task subpackage dependency in scmultiplex.

jluethi commented 2 months ago

This is now fixed in fractal-tasks-core 1.2.1. The utils function can now be imported as from fractal_tasks_core.utils import create_well_acquisition_dict and no extras are required.

I'll create a PR (likely next week) for updating this dependency. It also contains the pydantic V2 switch, which shouldn't be too tricky for this repo I think