This is the updated version of the PR with your changes merged in from main.
I made a PR here to update to the newest version of fractal-tasks-core. The core update concerns using pydanticV2 => different syntax for the fractal task function validation. Due to pre-commit, there are lots of minor changes though in the task functions. They are all just automated syntax updates, not manual changes by me.
Further additions:
I also added the fix for the numpy floats that should allow us to relax the numpy dependency (I kept it pinned under 2, as I'd expect that there may be additional issues there) => closes #104
Fix the import of create_well_acquisition_dict to work with new fractal-tasks-core version => closes #113
Very minor syntax fixes by running pre-commit across the task functions. That also found 2 variables that were defined and never used (see FIXME comments). Do you want to keep using pre-commit? Happy to help setting it up in your local dev environment if that's useful for you
I noticed that the manifest wasn't fully up-to-date. Part of it was just an unexpected ordering of entries (dunno where that came from). I now updated the manifest (makes tests pass on the fractal-tasks-core side, because we also check whether our manifest creation breaks scmultiplex manifests) & added tests to check that the manifest that's on Github is up-to-date with the source code.
Very minor typing update to the measurement task to ensure not providing any intensity channels to measure still works in pydanticV2 world
The PR would be ready for review from your side. Let me know if any questions come up
Hey @nrepina
This is the updated version of the PR with your changes merged in from main.
I made a PR here to update to the newest version of fractal-tasks-core. The core update concerns using pydanticV2 => different syntax for the fractal task function validation. Due to pre-commit, there are lots of minor changes though in the task functions. They are all just automated syntax updates, not manual changes by me.
Further additions:
The PR would be ready for review from your side. Let me know if any questions come up