Handle transmission channel metadata - Githubissues

fmi-faim / faim-ipa

A collection of Image Processing and Analysis (IPA) functions used at the Facility for Advanced Imaging and Microscopy (FAIM)

BSD 3-Clause "New" or "Revised" License

9 stars 6 forks source link

Handle transmission channel metadata #143

Closed tibuch closed 5 months ago

tibuch commented 5 months ago

How should we handle transmission channel metadata here: https://github.com/fmi-faim/faim-ipa/blob/39861cedc317986375846812fb0722e99096b574/src/faim_ipa/io/ChannelMetadata.py#L14

Before the latest release it was possible to set a string and we could simply put the channel name (see here). Now we are forced to put a number.

I understand the argument against putting a string. Should we make it Optional and accept None?

What do you think @imagejan ?