Issue in stitching.stitching_utils.fuse_linear

fmi-faim / faim-ipa

A collection of Image Processing and Analysis (IPA) functions used at the Facility for Advanced Imaging and Microscopy (FAIM)

BSD 3-Clause "New" or "Revised" License

7 stars 6 forks source link

Issue in stitching.stitching_utils.fuse_linear #154

Open fstur opened 6 days ago

fstur commented 6 days ago

In the fuse_linear function, there is an issue if the overlap region is at the border of the chunk: The weights are then calculated incorrectly. The fuse_linear function is missing some context of adjacent chunks. It's probably easiest to calculate the weights already in the warp_yx function.

https://github.com/fmi-faim/faim-ipa/blob/99a995484d2487aa5bc195e761acc360b18e0d7d/src/faim_hcs/stitching/stitching_utils.py#L10C1-L45C64

tibuch commented 2 days ago

Hi @fstur,

Thank you for reporting this bug. Are you already working on a fix?

fstur commented 2 days ago

Hey @tibuch, Not yet. I was planning to work on it this week, but feel free to look into it.

tibuch commented 2 days ago

Awesome! Looking forward to the PR!