Created logger does not log INFO level

fmi-faim / faim-ipa

A collection of Image Processing and Analysis (IPA) functions used at the Facility for Advanced Imaging and Microscopy (FAIM)

BSD 3-Clause "New" or "Revised" License

9 stars 6 forks source link

Created logger does not log INFO level #167

Closed tibuch closed 3 months ago

tibuch commented 3 months ago

Something changed with logging and our create_logger function returns a logger which does not log INFO events. Setting logger.setLevel('INFO') fixes the issue.

imagejan commented 3 months ago

Thanks, I just had noticed this last week as well. It seems we can then remove the redundant setting on the handler as it'll only receive messages with the logger's level and above anyway, right?

https://github.com/fmi-faim/faim-ipa/blob/caa6f39ffc5fac0e0f13a1a336d7b6f817e31f15/src/faim_ipa/utils.py#L76

tibuch commented 3 months ago

Probably. I did not test what happens if it gets removed.

imagejan commented 3 months ago

👍 I opened https://github.com/fmi-faim/faim-ipa/pull/169.