search

fmi-faim / faim-ipa

A collection of Image Processing and Analysis (IPA) functions used at the Facility for Advanced Imaging and Microscopy (FAIM)
BSD 3-Clause "New" or "Revised" License
9 stars 6 forks source link

ImageXpress: support single-channel acquisitions #90

Closed imagejan closed 9 months ago

imagejan commented 10 months ago

Relax filename pattern to allow missing channel group: when the channel info is missing from the filename, we default to 0.

Closes #89.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f94232a) 99.11% compared to head (7932365) 99.13%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #90 +/- ## ========================================== + Coverage 99.11% 99.13% +0.01% ========================================== Files 46 46 Lines 2722 2760 +38 Branches 268 273 +5 ========================================== + Hits 2698 2736 +38 Misses 16 16 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

imagejan commented 10 months ago

@tibuch I tested locally with a single-channel dataset, but ran into ValidationErrors because the input for ChannelMetadata.wavelength seems to be float(0.0) with this dataset. The rest seems to be fine, we'd just need a smaller single-channel test dataset to add a test for the new logic.

tibuch commented 10 months ago

I fixed a couple things (#91) and rebased this branch.