fmicompbio / monaLisa

binned motif enrichment analysis and visualisation
https://fmicompbio.github.io/monaLisa/
GNU General Public License v3.0
36 stars 6 forks source link

Add stabsel directionality plot 2 #31

Closed machlabd closed 4 years ago

machlabd commented 4 years ago

added new plot function for stability selection. One thing that's crossed my mind is that with all these functions it would look much neater if I had one summarized experiment object instead of requesting so many parameters for every plotting function (all that's related to stability selection part). I've so far stuck to this so that i have a 'stabs' object (since we use that package to do stability selection) but maybe it's worth rethinking or restructuring after this merge.

codecov[bot] commented 4 years ago

Codecov Report

Merging #31 into master will increase coverage by 0.16%. The diff coverage is 95.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage    90.2%   90.36%   +0.16%     
==========================================
  Files           8        8              
  Lines        1082     1121      +39     
==========================================
+ Hits          976     1013      +37     
- Misses        106      108       +2
Impacted Files Coverage Δ
R/plotting.R 99.11% <95.12%> (-0.89%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e66a1ea...9c690d8. Read the comment docs.

mbstadler commented 4 years ago

I agree with your comment about the SE as a return value also for stabsel. It would make things more consistent with the other parts of monaLisa. Feel free to open an issue if like.

mbstadler commented 4 years ago

Do I understand correctly that the branch add_plot_for_stabsel is not needed anymore and can be deleted?