search

fmidev / fmi-avi-messageconverter-iwxxm

Conversion module for aviation IWXXM messages
MIT License
7 stars 5 forks source link

TAF parser fails with CAVOK #78

Closed petringo closed 3 years ago

petringo commented 3 years ago

When parsing an IWXXM message with cloudAndVisibilityOK="true", you'll get a false conversion issue:

MISSING_DATA:Missing visibility in base forecast

For IWXXM 2.1.1 TAF the resulting TAFBaseForecast.ceilingAndVisibilityOk is erroneously false, for IWXXM 3.0.0 TAF the resulting TAFBaseForecast.ceilingAndVisibilityOk is correctly true.

This was tested with base forecast, change forecasts should be tested as well.

petringo commented 3 years ago

@patrick-alaspaa could I assign this to you?

patrick-alaspaa commented 3 years ago

Yes, I'd be happy to work on this!

patrick-alaspaa commented 3 years ago

I created a pull request with a fix for this issue

petringo commented 3 years ago

Thanks! Merged into master.