fmidev / fmi-avi-messageconverter-tac

Conversion module for aviation TAC messages
MIT License
1 stars 4 forks source link

Consider making SigmetBetweenLatOrLon regex stricter #158

Open kasarit opened 1 year ago

kasarit commented 1 year ago
private static String re1="((N|S)\\sOF\\s([NS]\\d{2,4})\\sAND\\s(N|S)\\sOF\\s([NS](\\d{2,4})))";
private static String re2="((W|E)\\sOF\\s([WE]\\d{3,5})\\sAND\\s(W|E)\\sOF\\s([WE](\\d{3,5})))";

Should the number of digits be stricter (2/3 + optional 2)? See https://github.com/fmidev/fmi-avi-messageconverter-tac/issues/154 for rationale.

Also make the regex strings private static final and fix the naming.