Fixes to locating to locations outside named locations

fmidev / weather-app

FMI's official weather application for mobile devices

7 stars 2 forks source link

Fixes to locating to locations outside named locations #527

Open AnttiRumpunen opened 7 months ago

AnttiRumpunen commented 7 months ago

currently locating does not work if located to coords. For example in sea. Forecast should work to coordinates. For observations, if there are no observations stations in 50km radius show message that no obs stations in 50km radius.
test is it possible to allow locating with lesser accuracy. Currently locating is disabled for some reason if user hasn't allowed accurate locating.

Test that the following works or not:

user is located to a location which is not in location database (for example 60.607803 24.873913 is located to hyvinkää/hakalanmäki-hakala, but it's not in location db). This might only be an issue in warnings though...

geosaaga commented 5 months ago

Seems that Smartmet Server returns location information for unnamed locations like this

{
  "nan": [
    {
      "name": "1.123,1.105",
      "latitude": 1.105,
      "longitude": 1.123,
      "region": "1.123,1.105",
      "country": null,
      "iso2": null,
      "localtz": "Europe/Lisbon"
    }
  ]
}

name is in incorrect format longitude, latitude. Standard way to present coordinates is latitude, longitude. Would be nice to get this fixed in Smartmet Server, but before that the app can format name manually from latitude and longitude fields.

geosaaga commented 5 months ago

60.607803, 24.873913 is located to Palopuro, Hyvinkää and seems to work fine (weather, warnings).