search

fmidev / weather-app

FMI's official weather application for mobile devices
7 stars 2 forks source link

Add version number to DynamicConfig #620

Closed geosaaga closed 2 weeks ago

geosaaga commented 2 months ago

Related to #616 DynamicConfig has update interval of 1 minute. However it rarely changes and there is not easy way to know has it changed or not. This causes unnecessary warning queries (at least). By adding version number to DynamicConfig and increasing it when doing changes we could avoid unnecessary updates. We could also save latest DynamicConfig to disk and make app startup faster using it. We could then update it later and save it to disk again if changed.

geosaaga commented 1 month ago

Amazon S3 calculates etag for every document/file and returns it in headers. Therefore there is no need to add version to config itself.

PR: https://github.com/fmidev/weather-app/pull/632