search

fmidue / haskell-template-task

Other
0 stars 0 forks source link

Fix module check #1

Closed marcellussiegburg closed 5 months ago

marcellussiegburg commented 3 years ago

Module parsing seems to fail if the module name does not match. Leading to a misleading error message: image

(Either) It should happen in the ParseError case here (or the module is written to the "wrong" location - but be careful to not expose internal modules if changing the latter): https://github.com/fmidue/haskell-template-task/blob/894c288b2d15bd6e7e9574c740e6f0769699f7a1/src/Haskell/Template/Task.hs#L571-L578

jvoigtlaender commented 5 months ago

Is this still relevant?

marcellussiegburg commented 5 months ago

I think this is not relevant any more. There have been changes on allowing different module names. Usually such changes are rejected because of a template mismatch (which is expected). If the issue reoccurs, this ticket might be reopened (or a new one created).