search

fmidue / logic-tasks

0 stars 1 forks source link

Remove redundancy at the `Resolve` task #102

Closed nimec01 closed 6 months ago

nimec01 commented 6 months ago

As mentioned in #101 completeGrade had some redundancy. This is probably a leftover from when I was not aware that completeGrade won't be evaluated when partialGrade already failed.

I added some tests for applySteps (even though we don't use it any more).

I also tried to add tests for gradeSteps which was not possible due to errors regarding OutputMonad image

jvoigtlaender commented 6 months ago

In test/ResolutionSpec.hs, a test could be added that manifests the insight from https://github.com/fmidue/logic-tasks/issues/101#issuecomment-1943804508, i.e., that applySteps includes checking against use of nonexisting clauses, like [({B}, {~B}, { })] as a step when not both of these singleton clauses have actually appeared before.

jvoigtlaender commented 6 months ago

(No tests for gradeSteps are necessary, I think.)