Closed nimec01 closed 6 months ago
As explained in https://github.com/fmidue/logic-tasks/issues/63#issuecomment-1960814640, my suggestion is now to put the replacing into illegalDisplay
.
Having it in generateLegalPropositionInst
is not so nice, since there it will also be applied to strings that don't even come from illegalDisplay
/implementIllegal
and thus can't possibly have a '_'
inside in the first place.
Also, putting the replacing into illegalDisplay
avoids having to "hack" the test suite.
Two other comments directly in the code view.
As explained in https://github.com/fmidue/logic-tasks/issues/63#issuecomment-1959764210