search

fmidue / logic-tasks

0 stars 1 forks source link

Provide additional feedback at SynTree task #70

Closed nimec01 closed 8 months ago

nimec01 commented 9 months ago

These changes should implement #33. However, I wasn't able to test this locally.

jvoigtlaender commented 8 months ago

The implementation of the tree showing looks okay to me. What I'm not certain of is whether the change of type of completeGrade is permissible. It probably depends on the API for Autotool integration. That is, how this function is expected to be called from there, and how paths can be provided.

Needs input from someone who can say more on that. (@owestphal, @marcellussiegburg?)

nimec01 commented 8 months ago

What I'm not certain of is whether the change of type of completeGrade is permissible. It probably depends on the API for Autotool integration. That is, how this function is expected to be called from there, and how paths can be provided.

Needs input from someone who can say more on that. (@owestphal, @marcellussiegburg?)

This type change was inspired by description, which also receives a path. The other option would be to provide a fixed path.