fmihpc / vlasiator

Vlasiator - ten letters you can count on
https://www.helsinki.fi/en/researchgroups/vlasiator
Other
47 stars 38 forks source link

gridGlue coupling is recomputed all the time instead of caching it #1007

Open ykempf opened 2 months ago

ykempf commented 2 months ago

We could store the coupling and recompute it when load balancing has occurred. But no, we do it every time. Also, we sort the cell lists twice, and we clear the maps that weren't reused anyway. So potential for cleanup and optimization there.

FIC spends about 5% in what I eyeball as mostly the recomputation of the coupling (though maybe it's also MPI to some extent). But whyyy didn't we bother caching that?!