search

fmihpc / vlasiator

Vlasiator - ten letters you can count on
https://www.helsinki.fi/en/researchgroups/vlasiator
Other
48 stars 39 forks source link

Update vlasiator to use updated fsgrid constructor #1019

Closed cscjlan closed 1 month ago

cscjlan commented 3 months ago

fsgrid doesn't use grid coupling to anything, so it was removed completely.

This should not be merged before the PR of fsgrid is merged, since the hash of the submodule may change in the merge.

cscjlan commented 2 months ago

Seems that tools/vlsvdiff.cpp doesn't include a header it needs (#include <iomanip>), which it got "accidentally" from fsgrid.hpp

markusbattarbee commented 1 month ago

We have a merge day upcoming - is this ready to be moved out of draft status? (remembering that the fsgrid commit needs updating after FSgrid PR 31)

cscjlan commented 1 month ago

Yes, this can be merged!