New amr criteria - Githubissues

fmihpc / vlasiator

Vlasiator - ten letters you can count on

https://www.helsinki.fi/en/researchgroups/vlasiator

Other

48 stars 39 forks source link

New amr criteria #1022

Closed lkotipal closed 2 weeks ago

lkotipal commented 2 months ago

New criteria for refinement:

Pressure anisotropy, refining if anisotropy is below AMR.anisotropy_threshold
Vorticity scaled to Alfven velocity, usage similar to alpha parameters

lkotipal commented 1 month ago

Now that I'm off vacation @JonasSuni please give your PR review in the PR, not the commits 😄

JonasSuni commented 1 month ago

Now that I'm off vacation @JonasSuni please give your PR review in the PR, not the commits 😄

My comments are in the PR to your branch :)

JonasSuni commented 1 month ago

Hmm, I guess the CI was run again, but there's still diffs. Are they still an issue?

lkotipal commented 1 month ago

Well the grid is the same, and this PR doesn't change anything except refinement behavior (with output after every pass iirc). So it's probably summation order, cosmic rays or whatever.