search

fmihpc / vlasiator

Vlasiator - ten letters you can count on
https://www.helsinki.fi/en/researchgroups/vlasiator
Other
48 stars 39 forks source link

Ghost translation dev merge #1060

Closed ursg closed 1 week ago

ursg commented 1 week ago

This is a merge of #1006 with the current, updated dev branch after the merges of the latter days.

Compiles cleanly, but let's run CI to see if I broke anything.

ursg commented 1 week ago

Ok, nope. This segfaults in Magnetosphere_polar_small in the testpackage, so I guess this needs to be merged more carefully.

ursg commented 1 week ago

Ah yes, one probably reasonably important hunk had fallen under the table in the merge there:

   // Prepare ghost translation cell lists and build pencils for translation.
   if (doTranslationLists) {
      prepareAMRLists(mpiGrid);
   }
ursg commented 1 week ago

And we're green across the board here. The testpackage has the same size mismatches for some AMR meshes (due to neighborhoods now being more snugly constructed), and in general the diffs look exactly the same as in #1006. So I am in favour of merging this now. Any objections?