search

fmilthaler / FinQuant

A program for financial portfolio management, analysis and optimisation.
MIT License
1.34k stars 190 forks source link

Refactor/stocks data as pdseries #92

Closed fmilthaler closed 1 year ago

fmilthaler commented 1 year ago

Refactoring data in class Stock. Previously this was of type pandas.DataFrame, but since this is data for only one stock, and FinQuant always considers only one price ('Adj. Closing Price') per stock, it makes more sense for Stock.data to be of type pandas.Series. This closes #91

fmilthaler commented 1 year ago

Just one curiosity: why change the order of inputs?

Quick answer: OCD (or rather CDO ;) )

Long answer: I saw that in some places, that the order of functions were not in alphabetical order. I made some manual changes there, because I have not set up pylint on this project yet.... maybe I should finally do that to automate that 🤣