fix(charts/ntfy): set default for service.ports.http{,s}

fmjstudios / helm

🪖 A collection of MIT-licensed Helm Charts

MIT License

8 stars 10 forks source link

fix(charts/ntfy): set default for service.ports.http{,s} #18

Closed Cogitri closed 1 week ago

Cogitri commented 2 months ago

What this PR does / why we need it

Otherwise, helm complains about a nil-value if http.service.ports.http isn't set.

Special notes for your reviewer

It seems that a few other values in the values file aren't used (e.g. nodePort), but I've left those unchecked for now.

Checklist

[X] Title of the PR starts with a valid commit scope as detailed in the CONTRIBUTING (e.g. fix(charts/linkwarden): ...)

github-actions[bot] commented 1 month ago

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

FMJdev commented 2 weeks ago

Hey @Cogitri, first of all sorry for leaving this open for so long. Life's been hectic and I even temporarily lost my development setup but I'm back now. I will be getting to your PR tomorrow afternoon!

FMJdev commented 1 week ago

Excuse the wait.. LGTM 👍🏼