search

fmo91 / MapKitGoogleStyler

Customize iOS MapKit using Google JSON styles
MIT License
132 stars 41 forks source link

Swift 4 #1

Closed staticdreams closed 7 years ago

staticdreams commented 7 years ago

I'm trying to implement this in Xcode 9.0 beta using Swift 4. It doesn't seem to work. No warnings or errors, I'm just getting empty map with no tiles. Do you know if your pod still works?

fmo91 commented 7 years ago

I haven't tried it in Swift 4 yet. But I've integrated it in a few projects using Swift 3 a few weeks ago and it worked fine. Have you tried the example? Does it work for you?

staticdreams commented 7 years ago

Well, your example isn't complete, but I used the code you provided in the description and I can confirm that it works fine in Xcode 8.3 / Swift 3 and the very same project fails to load map tiles when compiled in Xcode 9.

I actually lied to you, when saying there were no warning :) I just never paid attention to it. We're getting

[BoringSSL] Function boringssl_context_get_peer_sct_list: line 1592 received sct extension length is less than sct data length

As far as I can tell BoringSSL if Google's OpenSSL. I'll see what I can dig up. I'd really want your pod to work in Xcode 9

fmo91 commented 7 years ago

I see.. Let me know if you find how to make it work in Swift 4. I'll merge your pull request.

staticdreams commented 7 years ago

Ok, as far as I can tell there is nothing wrong with your code, nor Google. I can see the pod requests custom tiles and we're getting them, but MapKit refuses to display them for some reason. Perhaps it's just a beta bug that will be resolved in the future builds.

staticdreams commented 7 years ago

Ok, the beta 5 is out and it seems the issue has been fixed by itself without intervention. We can confide this closed now :)