search

fmod / fmod-for-unreal

FMOD Studio integration with Unreal.
https://fmod.com/resources/documentation-unreal
MIT License
202 stars 84 forks source link

Suppressed warning about banks with locales not matching setting, when they actually do #76

Open gamecentric opened 1 year ago

gamecentric commented 1 year ago

Banks with non-default locale are never recognized even if suffix is correct

fmod-cameron commented 1 year ago

What do you mean by they are never recognized? The banks are stored by GUID and localized banks all share the same GUID.

gamecentric commented 1 year ago

In the code affected by my PR, banks paths are being compared, not GUIDs.

fmod-cameron commented 1 year ago

Here the bank strings are compared to determine which banks to add to the map of bank guids/paths, the strings are compared because localized banks all share the same GUID. The map uses the GUID as the key so you cannot have multiple entries using the same key, which is why we only want to use the locale that is marked as 'bDefault'.

Are you having any issues or errors related to this?

gamecentric commented 1 year ago

The issue is that the warning message "Ignoring bank %s as another bank with the same GUID is already being used.\nBank %s does not match any locales in the FMOD Studio plugin settings." (see line 280) is always output for all non-default banks even if the bank actually matches locales in the settings.

gamecentric commented 1 year ago

Now I see, My original PR was wrong since the guid must be added to the map only for default locales. I updated the PR, so that only the warning is suppressed for non-default locales, while keeping the original logic.

fmod-cameron commented 1 year ago

Thanks, I have raised this a task that will be scheduled for a future release.