fmontesi / linter-jolie

A Jolie linter for Atom (via Atom Linter)
MIT License
1 stars 1 forks source link

Linter not working under WIndows 10 #4

Open bmaschio opened 8 years ago

bmaschio commented 8 years ago

@fmontesi I have tried to install Atom and the relative jolie packages but it seems to not work image

I think it is a problem with the location where jolie.bat is

also if i run as script from atom

image

but I run jolie from cmd

image

I am not sure what to think

fmontesi commented 8 years ago

Confirmed, I have the same issue on Windows 10.

It seems that we are not the only ones with this problem. It appears also with Python and PHP, and probably others. I see that in linter-php they decided to offer a configuration variable to allow users to fix it: https://atom.io/packages/linter-php

I haven't touched configuration yet, but it looks pretty easy to add judging from their code: https://github.com/AtomLinter/linter-php/blob/master/lib/main.coffee

I'm a bit short on spare time though.. maybe somebody at @mp2016/students has the same problem?

bmaschio commented 7 years ago

@fmontesi

I have added two console.log in coffee script line 18 console.log(editor.getPath()) line 20 console.log(data.stderr)

C:\Progetti\RilevazioneTimbrature\Leonardo\leonardo.ol main.coffee:20 "jolie" non � riconosciuto come comando interno o esterno, un programma eseguibile o un file batch.

Sorry for the italian it seems that it does not recognise the jolie command

fmontesi commented 7 years ago

I've added a new setting to point out the executable path explicitly. Try it out.

bmaschio commented 7 years ago

@fmontesi

my Atom since to have not noticed the update to 0.70

image

fmontesi commented 7 years ago

Weird, it should.. :-/

bmaschio commented 7 years ago

@fmontesi Have you got in mind the Donald Duck cartoons that is me with window today. but I arrived to a sort of conclusion the problem is not so much in path of jolie but how it is generated the command string to be passed to the cmd. Atoms tryes to execute a command line that looks like "C:\Windows\System32\cmd.exe" "/s" "/d" "/c" ""C:\Windows\System32\jolie.bat "--check" "C:\Progetti\PortaleManutenzioneAndroid\Leonardo\leonardo.ol"""

this is given by my atom version (1.12.4) line 52 file:///C:/projects/atom/out/app/src/buffered-process.coffee

that adds some ""

This is a know problem: https://github.com/atom/atom/issues/3200 https://github.com/atom/atom/pull/3208

in theory should been solved

Lets see

bmaschio commented 7 years ago

@fmontesi

Opened a new issue on Atom Project https://github.com/atom/atom/issues/13295

bmaschio commented 7 years ago

@fmontesi They bounced me to this repository https://github.com/steelbrain/exec I was pondering how the dependencies works in our linter

"dependencies": { "atom-linter": "^3.1.0", "atom-package-deps": "^2.0.1" },

how do I have to read ^3.1.0 If you go https://github.com/steelbrain/linter that I think is the correct repository you find in package definition

"version": "1.11.4",

Are we pointing to the wrong version??' or am I getting something complacently wrong

tnk B

fmontesi commented 7 years ago

The "dependencies" are deps on NPM packages, so not the linter atom package you linked.

The dependencies from Atom packages are in "package-deps".

On Tue, Nov 22, 2016 at 12:24 PM, Balint Maschio notifications@github.com wrote:

@fmontesi https://github.com/fmontesi They bounced me to this repository https://github.com/steelbrain/exec I was pondering how the dependencies works in our linter

"dependencies": { "atom-linter": "^3.1.0", "atom-package-deps": "^2.0.1" },

how do I have to read ^3.1.0 If you go https://github.com/steelbrain/linter that I think is the correct repository you find in package definition

"version": "1.11.4",

Are we pointing to the wrong version??' or am I getting something complacently wrong

tnk B

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fmontesi/linter-jolie/issues/4#issuecomment-262216508, or mute the thread https://github.com/notifications/unsubscribe-auth/AB-xyTX5SM7TVlveap1C0-8nFpZsFrUMks5rAtD0gaJpZM4IQXyA .

bmaschio commented 7 years ago

@fmontesi so https://github.com/steelbrain/linter it is NPM package so i wander why we link at 3.10 when the version is 1.11.4

bmaschio commented 7 years ago

@fmontesi I opened a new issue on the npm sb-exec https://github.com/steelbrain/exec/issues/59

Arcanemagus commented 7 years ago

I just installed this language, language-jolie and checked out linter-jolie. The program is being executed properly on Windows 10 x64 for me currently.

It looks like when this was filed this linter was still using an old version of the atom-linter helper library, which has since been corrected in v0.7.1. Are you still having issues on that version @bmaschio?

fmontesi commented 7 years ago

@arcanemagus Correct! I imagined bumping that version would help this issue, but I haven't tested it on Windows 10. Thanks for reporting that it works for you. @bmaschio Do you have the latest version of linter-jolie?

fmontesi commented 7 years ago

(it was @bmaschio himself to find out we were outdated)

bmaschio commented 7 years ago

@Arcanemagus thanks for helping @fmontesi I am still having problem with windows 8.1 Pro

My language-jolie "version": "0.4.5"

My linter-jolie "version": "0.7.1"
my atom-linter version is

    "raw": "atom-linter@^8.0.0",
    "scope": null,
    "escapedName": "atom-linter",
    "name": "atom-linter",
    "rawSpec": "^8.0.0",
    "spec": ">=8.0.0 <9.0.0",
    "type": "range"

am I getting something wrong

Arcanemagus commented 7 years ago

@bmaschio Can you completely remove the linter-jolie folder from The C:\Users\username\.atom\packages folder, then run apm install linter-jolie in order to get a fresh start? (Note that this won't wipe any settings.)

bmaschio commented 7 years ago

@Arcanemagus No changes!! Is it possible something to do with Promise and window 8? when is _child_process.spawn

 spawnedProcess.on('close', function (exitCode) { it returns exitCode =1
Arcanemagus commented 7 years ago

@bmaschio What is the exact error you are getting now?

bmaschio commented 7 years ago

@Arcanemagus

stderr = ""C:\Windows\system32\jolie.bat" non � riconosciuto come comando interno o esterno, ↵ un programma eseguibile o un file batch."

exactly as before..

Arcanemagus commented 7 years ago

And what do you get from where.exe jolie?

bmaschio commented 7 years ago

In C:\Windows\system32\

Am I missing something?

Arcanemagus commented 7 years ago

No, I mean what do you get when you run the command where.exe jolie on the CLI?

For example: image

bmaschio commented 7 years ago

@Arcanemagus

image

I have set now with even capital S

image

but the result is the same

image

thanks

Balint

Arcanemagus commented 7 years ago

Can you run the following two commands?

C:\Windows\System32\cmd.exe /s /c "jolie "--version""
C:\Windows\System32\cmd.exe /s /c ""jolie" "--version""

I'm wondering if you are somehow hitting a variant of https://github.com/steelbrain/exec/issues/36.

Arcanemagus commented 7 years ago

Also, in Atom can you go File -> Config... and copy the contents related to linter-jolie

For example:

  "linter-jolie":
    jolieExecutablePath: "C:\\Jolie\\bin\\jolie.bat"
bmaschio commented 7 years ago

they both worked

image

and

image

Arcanemagus commented 7 years ago

That's what I'm seeing as well, which is the case for most programs, but some are buggy...

Anyway can you post the config value?

bmaschio commented 7 years ago

image

bmaschio commented 7 years ago

@Arcanemagus maybe I am being cheeky have you got hangout?

Arcanemagus commented 7 years ago

Yep, I'm also on Atom's Slack.

bmaschio commented 7 years ago

would you find it easy on Hangout?

bmaschio commented 7 years ago

@Arcanemagus

Ok the java linter it works fine on my pc

image

It must be something to do with jolie.bat

Talk soon

Arcanemagus commented 7 years ago

How bizarre 😕.