Error if more then a file opened in Atom

fmontesi / linter-jolie

A Jolie linter for Atom (via Atom Linter)

MIT License

1 stars 1 forks source link

Closed bmaschio closed 7 years ago

bmaschio commented 8 years ago

The following linter command gives a range error

issue.range = helpers.rangeFromLineNumber editor, lineStart, colStart gives the following error

This is given by the following reasons

At the starting of the editor all the files are processed together
If in fileA the error is present at line 100 but the focused file has only 80 lines the editor gives the out of range errror

I have removed the line above and it seems to have no negative effect on the behavior, what is the reason to have that line? Thanks Balint

fmontesi commented 8 years ago

That line calculates the length of the line to be highlighted in the text. We can apply two fixes:

remove the last parameter, i.e., switch to issue.range = helpers.rangeFromLineNumber editor, lineStart
catch the Error from rangeFromLineNumber, in which case we just do not modify issue.

About the second item: rangeFromLineNumber seems to throw an Error when it doesn't like our input:

We could just catch that.

Arcanemagus commented 7 years ago

You might also look into why the invalid input is being generated in the first place 😉.

That check was put in there specifically to catch bugs in linters and has resulted in many fixes to ESLint stylelint and flake8 that I know of.