search

fmoo / react-typeahead

Pure react-based typeahead and typeahead-tokenizer
ISC License
677 stars 229 forks source link

Use upstream keydown handler if the user is pressing shift #105

Closed rgoldfinger closed 9 years ago

rgoldfinger commented 9 years ago

I would like to allow the user to be able to shift-tab to navigate backwards from a Typeahead input. However, the _onKeyDown handler was capturing it as a "tab".

Since none of the built in handlers are looking for "shift", I fixed this issue by passing the keyDown event directly up to the handler if the shift key is pressed.

thehuey commented 9 years ago

Looks okay to me. :+1:

fmoo commented 9 years ago

1.1.4 published to npm with this feature. Thanks for the PR!