fmoo / react-typeahead

Pure react-based typeahead and typeahead-tokenizer
ISC License
677 stars 231 forks source link

only display options list if not empty #112

Open magalhas opened 9 years ago

magalhas commented 9 years ago

When there were no visible items the

fmoo commented 9 years ago

I haven't read through the rest of the code lately, but does this break anything that assumes "sel" is a valid reference anywhere else?

magalhas commented 9 years ago

From my experience it's not throwing any errors, but yeah the ref won't be available with this if statement.

I wanted to put this logic inside the List component, though you can't return undefined / null on a render method.

magalhas commented 8 years ago

It would be awesome if this could be included so that we can stop using our fork git dependency.

fmoo commented 8 years ago

Can you rebase and move the logic into _shouldSkipSearch() ?

magalhas commented 8 years ago

@fmoo done.

fmoo commented 8 years ago

Hey, we've had a couple of regressions lately, would you mind including a unit test for this as well?

magalhas commented 8 years ago

Sure, not sure when I'll be able to pick this up though. What about my other 2 PRs?