Open magalhas opened 9 years ago
I haven't read through the rest of the code lately, but does this break anything that assumes "sel" is a valid reference anywhere else?
From my experience it's not throwing any errors, but yeah the ref
won't be available with this if statement.
I wanted to put this logic inside the List component, though you can't return undefined / null on a render
method.
It would be awesome if this could be included so that we can stop using our fork git dependency.
Can you rebase and move the logic into _shouldSkipSearch()
?
@fmoo done.
Hey, we've had a couple of regressions lately, would you mind including a unit test for this as well?
Sure, not sure when I'll be able to pick this up though. What about my other 2 PRs?
When there were no visible items the
was being rendered without need.