Closed fmr closed 9 years ago
Please merge, bump version and publish. Thank you
Per https://github.com/fmoo/react-typeahead/pull/131, 0.14 is out so...
Thanks @dminkovsky. It should just work now without these changes. Cheers!
It does! Thank you for this component!
On Tuesday, October 13, 2015, Francis Reyes notifications@github.com wrote:
Thanks @dminkovsky https://github.com/dminkovsky. It should just work now without these changes. Cheers!
— Reply to this email directly or view it on GitHub https://github.com/fmoo/react-typeahead/pull/135#issuecomment-147899192.
@fmr - how did you make this work without any changes? also, is this related to #137 at all?
@fmoo, the main issue I was having was that npm was complaining about peer dependencies. Since I was using 0.14.0-rc1
, npm couldn't resolve it, even though >= 0.13.0
is specified in package.json
. Since 0.14.0
is officially out, I've just changed my project to use the stable release.
e.g.
var input = this.refs.giraffe.getDOMNode();
is now:
var input = this.refs.giraffe;
You can also use findDOMNode
(at least, until 0.15 comes out), so this:
this.getDOMNode()
can be turned into this:
ReactDOM.findDOMNode(this)
Peer dependency requirements break when using react
0.14.0-rc1
. This PR allows for the release candidate to be used, while still allowing react0.13
as a peer dependency.