Changed classnames to peer dependency

fmoo / react-typeahead

Pure react-based typeahead and typeahead-tokenizer

ISC License

677 stars 230 forks source link

Changed classnames to peer dependency #153

Closed banghui closed 8 years ago

fmoo commented 8 years ago

Probably a dumb question but why?

banghui commented 8 years ago

haha i can't really answer that myself. I initially wanted to submit a pr just to change classnames dependency to >= 1.2.0 since there were some perf improvements made in ver 2. And then i thought, well, classnames seems like a pretty popular repository maybe it would make sense to have it as a peer dep instead. That being said, it maybe a problem for those using npm 3...