search

fmoo / react-typeahead

Pure react-based typeahead and typeahead-tokenizer
ISC License
677 stars 232 forks source link

use of React.__spread #172

Closed VinSpee closed 8 years ago

VinSpee commented 8 years ago

It seems as though React.__spread is a private method, any reason you're using it instead of an Object spread polyfill or something similar?

https://github.com/facebook/react/blob/6a8ebfc41842fb200c87a919478dcd3aa95be0d7/src/isomorphic/React.js#L70

fmoo commented 8 years ago

No good reason afaik. Please send a PR and ill merge it ASAP.

VinSpee commented 8 years ago

looks like it's in the dist directory, so it's likely react using it in a non-JSX version - my bad!

fmoo commented 8 years ago

Turns out there was actually something screwed up. Should be fixed in 1.1.9