Closed zdhickman closed 4 years ago
Please leave the lib/ out of the PR; lib is compiled as part of prepublish
automatically.
@nosilleg - Was thinking of getting this into the 1.1.x release; any concerns if I do?
What is the usage scenario for this change? This seems like it would impact a lot of different use cases. Is there an issue (ticket) for this? If not, can an issue be created so that we can discuss the validity of the functionality change? (as opposed to addressing the code in here)
@fmoo Thanks for including me on this. I've got other changes that are part completed for the next rev of the component (obvs pending your approval) one of which is the potential removal of defaultValue if/when I confirm that it's redundant in the controlled component version.
@nosilleg - I think the main issue is #151 (also #21?), but there are 2-3 other reports/questions around typeahead on textentry.blur / non-focus that could be related (#169, #154, #129, #115, #113, and maybe #104)
Following up on https://github.com/fmoo/react-typeahead/issues/151, this is an implementing patch if you'd like it!