Closed export-mike closed 8 years ago
we need to move away from using defaultValue as its now a react thing and not just a react-typeahead thing. defaultValue is for uncontrolled components we can use value. http://facebook.github.io/react/docs/forms.html#controlled-components
I've bumped to 2.0.0 to move from using defaultValue to using initial value, tests passing.
testing scripts inspired by airbnb's enzyme testing library. https://github.com/airbnb/enzyme/blob/master/package.json
anyone waiting on this theres a public fork on @pebblecode/react-typeahead
@export-mike - any preference on going straight to 2.0.0 vs doing a 2.0.0-rc.1?
Any guidance on whether this conflicts with #167? If I'm going to version bump to 2.0.0 I'd like to make sure we get other breaking changes in at the same time.
cc @nosilleg
@fmoo This dropped off my radar. I had made some v2 changes and was in the process of setting up React Storybook to try and get some use cases documented. I've done a hasty patch to try and get rid of that aspect, and there's a big TODO
left for inputProps, but this is the general direction that I was going...
https://github.com/fmoo/react-typeahead/compare/master...nosilleg:v2?expand=1
Another change would have been to remove defaultValue
since its not valid for a controlled component.
@fmoo no preference, happy to version the release candidate(s), @nosilleg funny you should mention storybook I thought about this yesterday. 👍 so is there much left todo?
I suck at npm, but this seems fishy: with the react 15 peerDep bump, should we bump react-dom and react-addons-test-utils as well?
npm WARN react-addons-test-utils@0.14.8 requires a peer of react@^0.14.8 but none was installed.
npm WARN react-dom@0.14.8 requires a peer of react@^0.14.8 but none was installed.
Released as react-typeahead@2.0.0-alpha.1
We shouldnt need to bump peer dependencies, within this branch I've added npm i react@0.14 and npm i react@15 as part of test scripts, this way we can support both. @fmoo what version of npm are you on?
Just a thought let's update the npm test script to call npm run test:all?
Cool I can test this out in a few hours I'm using my phone atm
what version of npm are you on?
npm --version 3.6.0
I'm on linux (Ubuntu)
I installed react 15.0.1 globally
If you remove react from global dependencies and use the new npm run test:react:14/15
On Thu, 21 Apr 2016 06:04 Peter Ruibal, notifications@github.com wrote:
what version of npm are you on?
npm --version 3.6.0
I'm on linux (Ubuntu)
I installed react 15.0.1 globally
— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/fmoo/react-typeahead/pull/183#issuecomment-212746852
I have identified warnings regarding the new warning added in react 15,
as discussed on react blog and github PR https://facebook.github.io/react/blog/2016/04/07/react-v15.html#new-deprecations-introduced-with-a-warning
https://github.com/facebook/react/pull/5048
This PR contains how to identify the problem:
new run script: npm run test:react:15
npm run test:react:14
I will submit a following PR to show how this will be fixed.