fmoo / react-typeahead

Pure react-based typeahead and typeahead-tokenizer
ISC License
677 stars 232 forks source link

Visible state not recalculated when parent changes maxVisible prop #185

Closed localjo closed 7 years ago

localjo commented 8 years ago

I'm using react-typeahead inside a parent component (a drop down menu in this case), and that component has the maxVisible value in it's state. Unfortunately, when that value changes and the typeahead is re-rendered it still uses the initial maxVisible value instead of the new value. I'm working on a fix and should have a PR ready in the next hour or so.