Recalculate visible items on maxVisible prop change

fmoo / react-typeahead

Pure react-based typeahead and typeahead-tokenizer

ISC License

677 stars 232 forks source link

Recalculate visible items on maxVisible prop change #187

Closed localjo closed 5 years ago

localjo commented 8 years ago

This fixes #185

The getOptionsForValue function was using the original value of maxVisible when the parent changed the prop. This makes sure that the function uses the new value and displays the correct number of visible items when the component is re-rendered. All tests pass.

localjo commented 5 years ago

Doing some housekeeping and closing this PR due to lack of activity. r9j94