fmoo / react-typeahead

Pure react-based typeahead and typeahead-tokenizer
ISC License
677 stars 229 forks source link

Token key passed as parameter in customClasses #261

Open vipulvkp opened 4 years ago

vipulvkp commented 4 years ago

value of token key passed under customClasses for Tokenizer is being used as the className for Token component and also for the tag that renders with a close action.

This is wrong . same class name will be used for both parent and child which screws up the design. Please separate them.

https://github.com/fmoo/react-typeahead/blob/master/src/tokenizer/token.js

https://github.com/wookiehangover/react-typeahead who has forked your original repo has hardcoded the className of to typeahead-token-close in https://github.com/wookiehangover/react-typeahead/blob/master/src/tokenizer/token.js.

please make this change in your repo as well or accept the change through a PR.

Update: Raised a PR. https://github.com/fmoo/react-typeahead/pull/262