search

fmoo / react-typeahead

Pure react-based typeahead and typeahead-tokenizer
ISC License
677 stars 231 forks source link

remove selectedTokens from change callbacks #80

Closed trshafer closed 9 years ago

trshafer commented 9 years ago

as requested in https://github.com/fmoo/react-typeahead/pull/79

trshafer commented 9 years ago

Hey @fmoo, is this a direction you're still interested in? I'd personally prefer to keep selectedTokens in the callback, but could be swayed, especially if there's an exposed component function to get the selected tokens.

fmoo commented 9 years ago

Yeah, an exposed component function makes a lot more sense before pulling this in.

I was also hoping to get a couple of bugfixes into 1.0.x before merging this and bumping to 1.1.x, but haven't had the time.

trshafer commented 9 years ago

Hey @fmoo, I appreciate the response.

The main reason I ask is purely selfish. I'm running off of this branch in prod because of this expected breaking change. npm outdated can't show if I'm outdated or not because it's running off a git sha. And I just prefer to be running off published versions. Let me know if I can help.

fmoo commented 9 years ago

@growlsworth - If you add the component function to this PR, I'll merge this in sooner than later. It seems super useful.

Thanks for your patience.

trshafer commented 9 years ago

Cool, should be an easy update. I can't work on it today, might have time this weekend.

trshafer commented 9 years ago

Added the exposed component function, documentation, and basic test. Let me know if you'd like for it to return a clone of the object instead of the object itself.