search

fmoralesc / pastie

a simple *nix clipboard manager with application-indicator support
47 stars 7 forks source link

create icon for pastie #17

Open kinkerl opened 14 years ago

kinkerl commented 14 years ago

it would be great for themes (read: ubuntu mono dark/light) to create custom icons for pastie.

maybe, for a first iteration, pastie could just use its own icon as a copie from gtk-paste and renamed for pastie. for mono themes, some nice mono icons for parcellite already exist on gnome-look and can be used as well.

atomfrede commented 14 years ago

Why not use the mono dark/light icons already available for parcellite?

kinkerl commented 14 years ago

yes its possible to use those. right now, pastie uses the gtk stock icon for copy and paste. if you overwrite this icon with the mono dark/light icon it would look nice in the panel but "every" paste icon in "every" gtk app will be mono. this will look very odd.

the solution would be: dont use the gtk stock paste icon. use a new name and copy the gtk stock icon. this would also allow pastie to ship with the mono dark/light icons in the first place so it could integrate out of the box.

fmoralesc commented 14 years ago

OK, but you can actually change pastie's icon without changing the paste icon. You can place the icon you want to use in a .pastie fodler in your home dir. (it should be called pastie.svg).

kinkerl commented 14 years ago

ah awesome! i only found a tutorials which used the gtk stock icon replacement. i think this was a pre pastie 0.4.5 hack? anyway, this works but its not an optimal solution. if you have time and motivation it would be great implement this icon as a automatic default version for mono themes. i did this for an application i wrote and and it really helps new users. not everybody has the knowledge and geekness to change this icon :)

thanks, i love pastie and use it every day!

fmoralesc commented 14 years ago

thanks for your support! =)

you're right, of course. i think the best solution would be that the icon themes include a "clipboard-manager" icon, so it's consistent with the theme (that was the idea of using the "gtk-paste" icon.). pastie (or any other clipboard manager) could simply use that. that would need coordination with the icon themes packagers, etc, so i'ts complicated.

the second best thing would be, as you propose, distribute the icons with pastie and then allow the user to change it from the preferences dialog.

atomfrede commented 14 years ago

Maybe we could try at least to get a "clipboard-manager-icon" into the Ubuntu-mono icon-set for maverick. Dropbox is by the way going to do the same instead of putting custom icons into .dropbox-dist. So maybe changes are good?

At least I could implement the choice in preferences dialog.

fmoralesc commented 14 years ago

I agree. But this change won't arrive at Maverick unless there's an Act of God involved. The User Interface Freeze for 10.10 was august 26th, and the Final Freeze is coming on september 16th. https://wiki.ubuntu.com/FinalFreeze Since pastie isn't in the official repos and there is no other clipboard manager doing this, I think this is difficult. I think it's best if we offer (for now) a supplementary icon package as a dependency for pastie, so pastie uses the "clipboard-manager" icon as default, and those who wish so, can override it with an icon in the .pastie dir. What do you think?

kinkerl commented 14 years ago

why do you want to create an icon package as a dependency?

i dont know how pastie implements this but i think it would be ok just to create those icons and ship them in the debian package. the application indicator supports icons depending on the theme:

just place default icon "clipboard-manager.svg" in the hicolor theme folder in /usr/share/icons and do the same for the mono-dark and light icons (/usr/share/icons/ubuntu-mono-dark folder)

in pastie, set the icon of the indicator to "clipboard-manager". the app indicator then choses the right icon to match the icontheme

fmoralesc commented 14 years ago

Since the possible use of the clipboard-manager icon is more general in scope than just for pastie, I thought it would be better to release it independently (so it's usable too for other people besides us, pastie-users. maybe that's being too nice? ;) ) Ok, then.