search

fmorbini / jmNL

modular NL platform for dialogue agents
Other
16 stars 2 forks source link

Fortify Changes #2

Open kellychristoffersen opened 7 years ago

kellychristoffersen commented 7 years ago

Do we want to merge in the changes that were made in response to the Fortify scans?

fmorbini commented 7 years ago

sure, they should be harmless, some useful some less but harmless. you should be able to merge it right?

kellychristoffersen commented 7 years ago

Yeah, do you want it to go your direction? Are you okay with more ICT having access to your main repository or would you prefer keeping it on a fork?

Hope all is well with you. We should catch up soon.

-- kø

Kelly Christoffersen 1.562.208.4182 me@kjc.us

On Sep 1, 2017, at 1:54 PM, fabrizio morbini notifications@github.com wrote:

sure, they should be harmless, some useful some less but harmless. you should be able to merge it right?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fmorbini/jmNL/pull/2#issuecomment-326681693, or mute the thread https://github.com/notifications/unsubscribe-auth/ADcikFU8kPuyWNvRnucKnTTEYJoERnBLks5seG72gaJpZM4PJrqS.

fmorbini commented 7 years ago

nah, it's no problem either way. But i think it's better if you just fork and maintain the fork.

kellychristoffersen commented 7 years ago

sounds good. we’ll pull any upstream updates if needed.

-- kø

Kelly Christoffersen 1.562.208.4182 me@kjc.us

On Sep 1, 2017, at 3:29 PM, fabrizio morbini notifications@github.com wrote:

nah, it's no problem either way. But i think it's better if you just fork and maintain the fork.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fmorbini/jmNL/pull/2#issuecomment-326696858, or mute the thread https://github.com/notifications/unsubscribe-auth/ADcikHxjOMda9EtqP8BiLT2ap7FWa35dks5seIUvgaJpZM4PJrqS.