search

fmperf-project / fmperf

Cloud Native Benchmarking of Foundation Models
Apache License 2.0
21 stars 10 forks source link

Move the imports of the tgis grpc stubs to where they are used #31

Closed maxdebayser closed 1 month ago

maxdebayser commented 2 months ago

With this change we can run with the vLLM backend without having to install this dependency.

maxdebayser commented 2 months ago

cc: @tdoublep

maxdebayser commented 2 months ago

Actually the I'm no longer sure if this PR makes sense because there is a dependency on the approx module that is used in both cases. Or maybe we could copy this module to this repo.

tdoublep commented 2 months ago

Actually the I'm no longer sure if this PR makes sense because there is a dependency on the approx module that is used in both cases. Or maybe we could copy this module to this repo.

Ah right. Maybe we could just copy it yeah

maxdebayser commented 2 months ago

Ah right. Maybe we could just copy it yeah

Done