Closed cmcghan closed 3 years ago
I skimmed the sources at the URL that you provide. Good work! I will review it more thoroughly. Is this the best place to give comments, or should I open issues in the tracker at https://github.com/cmcghan/vagrant-fmr2016?
Did you know about remote/Vagrantfile?
Sure, please do! :) You can give comments either here or at the tracker at https://github.com/cmcghan/vagrant-fmr2016 -- whichever is most convenient for you. I should see notifications in either place.
I did not know about the remote/Vagrantfile in the fmrbenchmark repo; guess I should've explored the subfolders a bit more :) Yours looks much more lightweight than mine. Mine is admittedly meant to be more of a 'one-click' creation that is fully set up and ready to go (or as close to as possible).
FYI, I'm planning on adding a 'FMRVERSION' command-line parameter to install_deps.sh, so that v0.0.1 or v0.0.2 can be chosen between. Hopefully this weekend.
In the section that contains git clone
, vagrant up
, and other commands of the README, should it use vagrant-fmr2016
instead of vagrant-rss
?
Yikes! Thanks -- fixed. Let me know if you find anything else? (And yeah, I'll need to get this working for v0.0.2-0.0.4 at some point...)
@cmcghan thanks for your work on this. following results #12, it is best to use Docker containers to provide for reliable reproduction of benchmarks and examples, e.g., domains/integrator_chains/Dockerfile. Using Docker has the additional advantage that controllers under evaluation can be separated from the benchmarks rather than having all code run as the same user on the same machine.
have you used this Vagrantfile since you opened this issue, and if so, are there some good use-cases you found that are not addressed by Dockerfiles?
closing this for now as it appears abandoned. @cmcghan feel free to open the discussion again.
This requires further testing, but I think(?!) this should work to create a fully-functional VirtualBox VM for fmrbenchmark v0.0.1, with all dependencies included.
Anybody interested in trying it out on their machine and giving me some feedback? :)
https://github.com/cmcghan/vagrant-fmr2016