dgarcu commented 7 months ago

Important!!!

[x] I have checked that this issue/bug/fix/correction has not been already created before in open or closed issues.

Type of bug

[x] A) Typo/error in Figure/text
[ ] B) Bug in code
[ ] C) General comment, recommendation or petition

Issue Description

A parameter from https://github.com/SteveMacenski/slam_toolbox online async launcher has been renamed in this PR: https://github.com/SteveMacenski/slam_toolbox/pull/363

More details: https://github.com/ros-planning/navigation2/issues/2240

Typo/Error Description

In the slides, chapter 6, slide 59/62:

ros2 launch slam_toolbox online_async_launch.py params_file:=[File path] use_sim_time:=true

From mentioned PR onwards, this should be:

ros2 launch slam_toolbox online_async_launch.py slam_params_file:=[File path] use_sim_time:=true

Proposal

I am aware of a new edition of the book being written, so I understand this has been updated already. However the docs from this very repo are outdated in that regard, so maybe leave this issue open until the docs are updated. :smiley:

Desktop:

OS:
ROS2 Distro:

fmrico commented 7 months ago

Thanks @dgarcu

I will maintain open this issue until it is fixed in the Second Edition.

Thanks!!

AESilky commented 2 weeks ago

Is this the cause of the error: fatel error: cv_bridge/cv_bridge.h: No such file or directory

If so, can you provide the fix for it in these comments? I am getting the error and haven't yet taken the time to track it down. If there is a known fix, that would save me some time.

Juancams commented 1 week ago

Commented and hopefully solved in #36 ^^

fmrico / book_ros2