Open dgarcu opened 7 months ago
A parameter from https://github.com/SteveMacenski/slam_toolbox online async launcher has been renamed in this PR: https://github.com/SteveMacenski/slam_toolbox/pull/363
More details: https://github.com/ros-planning/navigation2/issues/2240
In the slides, chapter 6, slide 59/62:
ros2 launch slam_toolbox online_async_launch.py params_file:=[File path] use_sim_time:=true
From mentioned PR onwards, this should be:
ros2 launch slam_toolbox online_async_launch.py slam_params_file:=[File path] use_sim_time:=true
I am aware of a new edition of the book being written, so I understand this has been updated already. However the docs from this very repo are outdated in that regard, so maybe leave this issue open until the docs are updated. :smiley:
Thanks @dgarcu
I will maintain open this issue until it is fixed in the Second Edition.
Thanks!!
Important!!!
Type of bug
Issue Description
A parameter from https://github.com/SteveMacenski/slam_toolbox online async launcher has been renamed in this PR: https://github.com/SteveMacenski/slam_toolbox/pull/363
More details: https://github.com/ros-planning/navigation2/issues/2240
Typo/Error Description
In the slides, chapter 6, slide 59/62:
ros2 launch slam_toolbox online_async_launch.py params_file:=[File path] use_sim_time:=true
From mentioned PR onwards, this should be:
ros2 launch slam_toolbox online_async_launch.py slam_params_file:=[File path] use_sim_time:=true
Proposal
I am aware of a new edition of the book being written, so I understand this has been updated already. However the docs from this very repo are outdated in that regard, so maybe leave this issue open until the docs are updated. :smiley:
Desktop: